Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(repo): Link local packages for e2e #4800

Merged
merged 7 commits into from
Dec 18, 2024
Merged

fix(repo): Link local packages for e2e #4800

merged 7 commits into from
Dec 18, 2024

Conversation

jacekradko
Copy link
Member

@jacekradko jacekradko commented Dec 17, 2024 •
edited
Loading

Description

Use link protocol for local E2E runs

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 17, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 12c4b42

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Dec 17, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 4:38pm

@jacekradko jacekradko marked this pull request as ready for review December 17, 2024 22:42
BRKalow
BRKalow reviewed Dec 18, 2024
View reviewed changes
integration/.eslintrc.js Outdated
Comment on lines 30 to 32
rules: {
'turbo/no-undeclared-variables': 'off',
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be better to add CI to turbo's global env vars instead of disabling here 👀

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can disable it on a per-use basis, but adding CI to turbo vars would create separate caches for tasks in CI versus local

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, true! Is anyone using turbo cache locally? 😅

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope so 🥲

@jacekradko jacekradko merged commit a9234f2 into main Dec 18, 2024
29 checks passed
@jacekradko jacekradko deleted the fix/local-e2e-link branch December 18, 2024 16:49
BRKalow pushed a commit that referenced this pull request Dec 20, 2024
@jacekradko @BRKalow
fix(repo): Link local packages for e2e (#4800)
f4283ca
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BRKalow BRKalow BRKalow left review comments

@anagstef anagstef anagstef approved these changes

Assignees
No one assigned
Labels
integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jacekradko @BRKalow @anagstef @clerk-cookie